Skip to content

test: set useradd defaults on suse images#22902

Draft
Lunarequest wants to merge 4 commits intocockpit-project:mainfrom
Lunarequest:useradd
Draft

test: set useradd defaults on suse images#22902
Lunarequest wants to merge 4 commits intocockpit-project:mainfrom
Lunarequest:useradd

Conversation

@Lunarequest
Copy link
Contributor

useradd doesn't have defaults on opensuse, instead we need to use self.write_file to create the default files instead of sedding the defaults

Copy link
Member

@martinpitt martinpitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Copy link
Member

@martinpitt martinpitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One more round, sorry!

absent_content is an argument to sed_file that will if the specified
path does not exist, create a file with the contents passed to it.
Copy link
Member

@martinpitt martinpitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Some minor cleanups needed, but let me trigger a round of opensuse-tumbleeed/other and fedora-43* tests.

@martinpitt
Copy link
Member

@Lunarequest Sorry, lots of accounts test failures 😢

@Lunarequest
Copy link
Contributor Author

This needs some wider changes, I'll be marking this as draft, and pulling a934db1f650156902c8ce0a93754ba1ec2131a38 into a simpler pr

@Lunarequest Lunarequest marked this pull request as draft February 23, 2026 05:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants